Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job notification ObjectDisposedException handling #4682

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

mikaelweave
Copy link
Contributor

@mikaelweave mikaelweave commented Oct 16, 2024

Description

Expand existing logging for mediatr ObjectDisposedExceptions to jobs. These exceptions are a side effect and should not percolate to the customer level.

Related issues

AB#130427

Testing

Local debugging

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • PR pipeline is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mikaelweave mikaelweave requested a review from a team as a code owner October 16, 2024 18:42
@mikaelweave mikaelweave added Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug. labels Oct 16, 2024
@mikaelweave mikaelweave added this to the S152 milestone Oct 16, 2024
@mikaelweave
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikaelweave mikaelweave added Bug Bug bug bug. and removed Bug Bug bug bug. labels Oct 16, 2024
@mikaelweave mikaelweave changed the title Addo ObjectDisposedException handling for mediatr notifications Add ObjectDisposedException handling for Mediatr notifications in jobs Oct 17, 2024
@mikaelweave
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikaelweave mikaelweave changed the title Add ObjectDisposedException handling for Mediatr notifications in jobs Add job notification ObjectDisposedException handling Oct 22, 2024
@mikaelweave
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikaelweave mikaelweave merged commit 5bb52a6 into main Oct 24, 2024
47 checks passed
@mikaelweave mikaelweave deleted the personal/mikaelw/add-publish-notification-handling branch October 24, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants