Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference to Uri Converter #4721

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

brendankowitz
Copy link
Member

@brendankowitz brendankowitz commented Nov 12, 2024

Description

This pull request introduces a new converter for transforming ReferenceSearchValue to UriSearchValue and includes corresponding unit tests to ensure the functionality is correctly implemented.

New Converter Implementation:

  • Added ReferenceToUriSearchValueConverter class to convert ReferenceSearchValue to UriSearchValue in ReferenceToUriSearchValueConverter.cs.

Unit Tests:

  • Introduced ReferenceToUriSearchValueConverterTests class to validate the new converter's functionality in ReferenceToUriSearchValueConverterTests.cs. Tests include scenarios for null, basic, and reference values.
  • Updated project file Microsoft.Health.Fhir.Shared.Core.UnitTests.projitems to include the new test file.

Related issues

Addresses [issue AB#131463].

Testing

Adds unit test
Manual testing with custom Reference to Uri search parameter also done.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@brendankowitz brendankowitz requested a review from a team as a code owner November 12, 2024 20:13
@brendankowitz brendankowitz added this to the S154 milestone Nov 13, 2024
@brendankowitz brendankowitz added Enhancement Enhancement on existing functionality. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Nov 13, 2024
@feordin feordin force-pushed the personal/bkowitz/adds-reference-to-uri-converter branch from f377b1e to f07b8b3 Compare December 3, 2024 19:59
@feordin feordin merged commit ea75818 into main Dec 3, 2024
48 of 49 checks passed
@feordin feordin deleted the personal/bkowitz/adds-reference-to-uri-converter branch December 3, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Enhancement Enhancement on existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants