Add new SQL hash calculation #4737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LTA-Thinking
added
Bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| public class ReadableLogger<T> : ILogger<T> | ||
| { | ||
| private List<string> _logs = new List<string>(); |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity Note test
feordin
previously approved these changes
Nov 26, 2024
abiisnn
reviewed
Nov 27, 2024
|
|
||
| public string GetHash() | ||
| { | ||
| // I don't think UnsupportedSearchParams is needed as it isn't used in the actual search |
There was a problem hiding this comment.
Is this comment meant to be committed? 🍒
There was a problem hiding this comment.
I should reword it, but I think the point is helpful to understand why I didn't include that value in the hash.
abiisnn
approved these changes
Nov 27, 2024
|
Waiting to merge until we can discuss the impact to existing custom queries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SQL query hash has been including parameter values when it shouldn't, which is causing custom queries to be parameter value specific. This is undesired as custom queries should apply regardless of parameter values. This PR changes the way query hashes are generated to remove parameter values.
This will change the hashes of all requests, which will render current custom queries invalid.
Related issues
Addresses Bug 131113: SQL query hashes have parameter value hashes included
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)