[FluentList] Set environment variable for styling so child views can utilize it #2023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
The
FluentList
andFluentItem
are designed to be used together but there will need to be some coordination between them for styling. This is so that the item can be styled to match the type of list.To achieve this, it seemed to make sense to use an environment variable so the list can set the list style and pass it to any child views that want to use it, like a
ListItem
view. This way implementors don't need to set a matching style on everyListItem
to be the same as the style of the wrappingFluentList
. We will be able to also use this value forFluentListSection
,FluentListSectionHeader
, andFluentListSectionFooter
.If an implementor for some reason still wanted to specify a different style on
ListItem
, we respect that value over the environment variable.Updated both the background color and the spacing for the
insetGrouped
list style.Binary change
Total increase: 36,016 bytes
Total decrease: 0 bytes
Full breakdown
Verification
Visual Verification
With
.grouped
style specified forListItem
With
.plain
style specified forListItem
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow