Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][macOS] Rework top-level file management #2090

Merged
merged 6 commits into from
Sep 25, 2024

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Sep 20, 2024

Platforms Impacted

  • iOS
  • visionOS
  • macOS

Description of changes

High-level summary of changes to structure:

Before:

.
├── Demo
├── ios
│   ├── FluentUI
│   ├── FluentUI.Demo
│   ├── FluentUI.Resources
│   └── FluentUI.Tests
├── macos
│   ├── FluentUI
│   ├── FluentUIResources-macos
│   ├── FluentUISwiftUITestApp
│   ├── FluentUITestApp
│   ├── FluentUITestViewControllers
│   └── FluentUIUnitTest
├── public
│   └── FluentUI.swift
└── scripts

After:

.
├── Demos
│   ├── FluentUIDemo (SwiftUI WIP)
│   ├── FluentUIDemo_iOS
│   └── FluentUIDemo_macOS
├── Sources
│   ├── FluentUI
│   │   └── FluentUI.swift
│   ├── FluentUI_iOS
│   │   ├── Core
│   │   ├── Components
│   │   └── Resources
│   ├── FluentUI_macOS
│   │   ├── Core
│   │   ├── Components
│   │   └── Resources
│   └── FluentUI_common (name TBD)
├── scripts
└── Tests
    ├── FluentUI_iOS_Tests
    └── FluentUI_macOS_Tests

Binary change

n/a - no changes to build output

Verification

  • Full build and test pass of both libraries
  • Built release schemes for both libraries
  • WIP: Podspec validation

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@mischreiber mischreiber requested review from a team as code owners September 20, 2024 18:22
@joannaquu
Copy link
Contributor

joannaquu commented Sep 25, 2024

can we also update the readmes/contributing.md. I just went through them and some still point to the xcodeproj oops.

@Saadnajmi
Copy link
Contributor

Dumb question: Is cocoa pods still supported after this?

@joannaquu
Copy link
Contributor

I believe our localization script also needs updating

@joannaquu
Copy link
Contributor

all our doc links will also be broken but maybe for another pr?

@mischreiber
Copy link
Contributor Author

Dumb question: Is cocoa pods still supported after this?

@Saadnajmi not dumb! Yes, I made extensive changes to the podspec in commit c3a919f to keep it building.

@mischreiber
Copy link
Contributor Author

@joannaquu updating docs, loc script, and readme now

@mischreiber mischreiber merged commit 2e35533 into microsoft:main Sep 25, 2024
7 checks passed
@mischreiber mischreiber deleted the reorganizePackage branch September 25, 2024 23:50
@mischreiber mischreiber mentioned this pull request Oct 17, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants