Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddRegular icon is not aligned vertically #733

Open
rocketBANG opened this issue Jul 9, 2024 · 2 comments
Open

AddRegular icon is not aligned vertically #733

rocketBANG opened this issue Jul 9, 2024 · 2 comments

Comments

@rocketBANG
Copy link

The + icon is not aligned with the text. It looks like it has more padding below than above which causes it not to line up when used with a button

345178510-75ba73ab-0388-49c8-8dee-9e83877137fe
345179022-9d42c003-9562-4716-99d8-7368590c5538

@mdtauk
Copy link

mdtauk commented Jul 9, 2024

There will always be an issue with these kinds of icons where in order to remain on the pixel grid, the icon needs to be shifted in an asymmetric position, so as to remain crisp.

@Jay-o-Way
Copy link

Jay-o-Way commented Jul 18, 2024

@mdtauk That's a negative.

The images that are used on the page https://learn.microsoft.com/windows/apps/design/style/segoe-fluent-icons-font are base-64px and a line is then 4px thick. This means lines will be able to go exactly through the center. If that is not the case for these icons, it should be?

In this specific size: 48 is divisible by 3 and therefore you can draw a 3px line through the center. Optically this is the same thickness as 64/4. This nullifies your argument.

Example image shows 8px padding on the top and 12px on the bottom.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants