Replies: 2 comments
-
@ecraig12345 could I ask you to take a look at this question, as it relates to the change you did in commit c838c58 in which the periods were dropped from the defaults for |
Beta Was this translation helpful? Give feedback.
0 replies
-
@paulgildea @gouttierre would you know anything about how the microsoft style guide should be applied to default strings in Fluent UI? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
When no
strings
prop is passed toDatePicker
, defaults are used in which the string forisRequiredErrorMessage
does not include a period:I’m not sure whether that is in line with the Microsoft Style Guide; compare ‘UI text or strings’ and ‘Error messages’ in the table on the page ‘Formatting common text elements’ where the examples for the former do not include a period but the examples for the latter do:
See also the page on ‘Periods’.
Conversely, the default string did include a period at some point:
fluentui/packages/date-time/src/components/DatePicker/defaults.ts
Lines 6 to 7 in fb87732
It was dropped in commit c838c58:
fluentui/packages/date-time/src/components/DatePicker/defaults.ts
Lines 11 to 12 in c838c58
I can’t quite make out from the commit message what the motivation for that change was though. Could some further clarification be provided on the proper use of punctuation for these error messages?
Beta Was this translation helpful? Give feedback.
All reactions