Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Narrator is not announcing "Collapsed"/"Expanded" when Dropdown is collapsed/expanded #11367

Closed
Lijing29 opened this issue Dec 4, 2019 · 6 comments

Comments

@Lijing29
Copy link

Lijing29 commented Dec 4, 2019

Environment Information

  • Package version(s): office-ui-fabric-react@7.67.0
  • Browser and OS versions: Narrator + Edge

Describe the issue:

Narrator would not announce 'collapsed' or 'expanded' when the dropdown is collapsed or expanded.

Please provide a reproduction of the issue in a codepen:

https://codepen.io/lijinglin29/pen/gObbvpg

Actual behavior:

Narrator does not read the State(Expand/Collapse) of the dropdown

Expected behavior:

Narrator should read the State(Expand/Collapse) of the dropdown

@khmakoto
Copy link
Member

khmakoto commented Dec 4, 2019

Hi @Lijing29, this is happening because of a recent change on what Narrator considers advanced information, among which is included the information of the aria-expanded attribute. You can check this by going into the codepen you provided, making focus be on the Dropdown and then pressing the [Narrator key] + 0 key combination, which reads advanced information. Upon doing that you should be hearing collapsed.

I don't know why the Narrator team decided to change behavior for it to be this way, but there is nothing we can do on the Fabric side to help with this.

@Lijing29
Copy link
Author

Lijing29 commented Dec 5, 2019

Thanks for the information. If possible, could you please give me the document which mentions that aria-expanded is treated as advanced information by Narrator? I could only find the document showing that Narrator + 0 would read item advanced. But I could not find any document defined what kinds of information are treated as advanced info.
Besides, it seems Narrator + 0 would only announce "Collapsed" when the dropdown is collapsed. and would not announce "Expanded" when it is expanded. Right? I could not find a method to let Narrator announce "Expanded". Do you have any suggestion about this part? Thanks.

@xugao
Copy link
Contributor

xugao commented Dec 5, 2019

@Lijing29 - here is an article which gives you some context https://winaero.com/blog/hear-advanced-information-about-controls-narrator-windows-10/.

Regarding it's not announcing "expanded", that is true. Narrator + 0 won't give you such info in the expanded case because focus is no longer on the dropdown but on the focused item in the dropdown options when it's expanded. May I ask why in that case you think it's necessary to announce "expanded" considering the other info it read out seems to provide sufficient knowledge for user?

@sajsarka
Copy link

sajsarka commented Dec 6, 2019

@xugao - Issue #11381 is specific to other browsers - Collapsed state is announced in IE and EDGE but not on chrome or Firefox. I tried with Narrator + 0, no help. Any workaround how collapsed state can be announced on Chrome/Firefox.
Kindly use the codepen link if needed to reproduce the issue.

@Lijing29
Copy link
Author

Lijing29 commented Dec 6, 2019

@xugao Thanks for the article. It seems that it is no necessary to announce 'expanded' in my case.

@xugao
Copy link
Contributor

xugao commented Dec 6, 2019

@sajsarka - i tried both chrome and FF too. when dropdown is on focus, Narrator + 0 announces
"Collapsed". Could you double check?
I am going to close this issue. If you continue to repro #11381, please go ahead reopen it and I will follow up more with you there :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants