Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatMessage throws error when used with children #16301

Closed
ling1726 opened this issue Dec 28, 2020 · 0 comments · Fixed by #16321
Closed

ChatMessage throws error when used with children #16301

ling1726 opened this issue Dec 28, 2020 · 0 comments · Fixed by #16321
Assignees
Labels

Comments

@ling1726
Copy link
Member

Environment Information

  • Package version(s): (fill this out)
  • Browser and OS versions: (fill this out if relevant)

Please provide a reproduction of the bug in a codepen:

Actual behavior:

When rendering ChatMessage with children, the following error will always be thrown since the header prop has a default value of {} which is inconsistent with other shorthand props for this component:

Warning: Failed prop type: Prop `author` in `ChatMessage` conflicts with props: `children`. They cannot be defined together, choose one or the other.

Repro: https://codesandbox.io/s/fluent-ui-example-forked-vg94c

Expected behavior:

No error should be thrown when rendering ChatMessage with children

Priorities and help requested:

Are you willing to submit a PR to fix? (Yes, No)

Yes

Requested priority: (Blocking, High, Normal, Low)

Normal

Products/sites affected: (if applicable)

Teams/TMP -> MessageRenderer component

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants