Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onScroll event of ScrollablePane is not fired while running on react version 17.0.2 #18744

Closed
arunvenu87 opened this issue Jun 28, 2021 · 6 comments · Fixed by #20123
Closed
Assignees
Labels
Component: ScrollablePane Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix Status: Fixed Fixed in some PR

Comments

@arunvenu87
Copy link

Environment Information

  • Package version(s): 8.20.2
  • react: 17.0.2

Describe the issue:

Actual behavior:

The onScroll event of ScrollablePane is not fired while using react version 17 .

Expected behavior:

The onScroll event of ScrollablePane should be fired.

If applicable, please provide a codepen repro:

It is working when react version 16.8.6 is used
https://codepen.io/arunvenu87/pen/gOWOPpq

It is not working when react version 17.0.2 is used
https://codepen.io/arunvenu87/pen/YzVzwPj

Priorities and help requested :

Are you willing to submit a PR to fix? No

Requested priority: High

@arunvenu87
Copy link
Author

This behavior might be related to this breaking change.

@gouttierre gouttierre added Component: ScrollablePane Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix and removed Needs: Triage 🔍 labels Aug 10, 2021
@gouttierre
Copy link
Contributor

@arunvenu87 - Thanks for filing this issue with us.

@smhigley - Would you be able to confirm if this is a regression, or if this behavior is an issue?

@bsunderhus
Copy link
Contributor

@bsunderhus
Copy link
Contributor

Seems like the onScroll method from the root element in ScrollablePane is not being invoked on v17.0.2 I'll be proposing a PR for a fix

@piedras77
Copy link

@bsunderhus any updates on when the pull request fixing this will be merged? Thanks

@Wezea
Copy link

Wezea commented Mar 8, 2022

Unfortunately, the PR expired and has been closed.

We would highly appreciate to get this merged, as this is currently blocking us to migrate to React v17.

@JustSlone JustSlone moved this from Good Issues (High Priority) to Help Wanted (Lower Priority) in Fluent UI - Shield Priors Mar 23, 2022
Repository owner moved this from Help Wanted (Lower Priority) to Done in Fluent UI - Shield Priors Apr 19, 2022
@msft-fluent-ui-bot msft-fluent-ui-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Apr 19, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: ScrollablePane Fluent UI react (v8) Issues about @fluentui/react (v8) Needs: Investigation The Shield Dev should investigate this issue and propose a fix Status: Fixed Fixed in some PR
Projects
Development

Successfully merging a pull request may close this issue.

7 participants