Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPOP with count bug #235

Closed
TalZaccai opened this issue Apr 4, 2024 · 6 comments · Fixed by #239
Closed

SPOP with count bug #235

TalZaccai opened this issue Apr 4, 2024 · 6 comments · Fixed by #239
Labels
bug Something isn't working

Comments

@TalZaccai
Copy link
Contributor

Another bug relating to SPOP - when calling SPOP with count greater than the set size, subsequent calls to SADD return an empty array.

Example:

image
@TalZaccai TalZaccai added the bug Something isn't working label Apr 4, 2024
@TalZaccai
Copy link
Contributor Author

@Zzhiter FYI - this is not related to your recent PR #136, but a new bug that I've discovered due to your fix.

@Zzhiter
Copy link
Contributor

Zzhiter commented Apr 5, 2024 •
edited
Loading

image
I repeated what you did and realized that when I entered the SADD command, it actually still judged it as a SPOP, which is why the response "(empty list or set)" looks like a bug introduced by this PR: 4cba6ff

@Zzhiter
Copy link
Contributor

Zzhiter commented Apr 5, 2024

@Zzhiter FYI - this is not related to your recent PR #136, but a new bug that I've discovered due to your fix.

Actually this fix is ​​not mine😂

@Zzhiter Zzhiter mentioned this issue Apr 5, 2024
Merged
@Zzhiter
Copy link
Contributor

Zzhiter commented Apr 5, 2024

image
I seem to have found the cause.
When calling SPOP with count greater than the set size，it will return false.
Fix: #239

@TalZaccai
Copy link
Contributor Author

@Zzhiter FYI - this is not related to your recent PR #136, but a new bug that I've discovered due to your fix.

Actually this fix is ​​not mine😂

Oops sorry, meant #191 :)

@TalZaccai
Copy link
Contributor Author

image I seem to have found the cause. When calling SPOP with count greater than the set size，it will return false. Fix: #239

Thanks for looking into it! I'll have a look at your PR :)

@TalZaccai TalZaccai linked a pull request Apr 6, 2024 that will close this issue
fix: SPOP with count bug #239
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: SPOP with count bug Zzhiter/garnet
2 participants
@TalZaccai @Zzhiter