-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix installer builds #442
Fix installer builds #442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just had one question about using your build-extra
fork.
.github: use partial clone for build-extra Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
…workflow .github: fix errant 'filename' variable At this point in the script, 'filename' contains a relative path to a file, but that does not resolve correctly. Remove the variable and place the filename directly within the path. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
.github: fix macOS installer build Update the macOS version strings to versions that reflect the build machines and allow us to compile the release builds including FS Monitor. Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
5ca6516
to
bb4e5de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks for the fixes!
cat $b/git-extra/git-update-git-for-windows && | ||
|
||
sed -i -e '/^# when confirmation to do so is given./a\ | ||
use_recently_seen=no' \ | ||
$b/git-extra/git-update-git-for-windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should target /mingw64/bin/git-update-git-for-windows
, correct?
I was working last week to update the
git-update-git-for-windows
script to repeat daily reminders to upgrade. I did not succeed in doing that, but I found some other issues that are resolved in this PR:git-for-windows/build-extra
repo.filename
variable that doesn't work in one place. Use the literal path instead.derrickstolee/git_osx_installer
, too.These changes were integrated in a successful run of the
build-git-installers
workflow.