[Regression] Type collisions for types referenced from OData actions

[andrueastman]

#1100 involved the refactoring of this function

This seems to have the side effect that the class name is no longer inferred from the URL but is now derived from the schema. This causes some type collisions (e.g in delta functions) as the type name now changes from Delta to the actual type name (e.g Messages,MailFolder) to cause ambiguity in request builders to cause compilation failures.

This is replicated when using the full open Api description.

Original

After

We can enforce lookup for types in all namespaces before calling this function. We might need to move some files to the default models folder.

[baywet]

Thanks for reporting this @andrueastman !
I noticed that while working on #1174 but I wasn't sure whether the behaviour was caused by previous changes or current ones.
The reason why I added the schema in the evaluation was to get the proper name for the error classes that was sometimes missing.
If you don't mind having a look at it, it'd be greatly appreciated!

[baywet]

Note: while working on that, you should also test with Mail.yml from this PR to make sure the error classes still get the right name.

[andrueastman]

No worries @baywet.

At the moment I can work around this by passing checkInAllNamespaces: true to the function here but that has the side effect of have crossing references across other namespaces.

[baywet]

yep, this should stay as it is, otherwise we'll start having race conditions that'll reference the wrong types in different namespace depending on the order of execution.
I think the right way to address this issue would be to pass the schema ONLY when we need it to get a more precise class name, or something along those lines.

[andrueastman]

I think the right way to address this issue would be to pass the schema ONLY when we need it to get a more precise class name, or something along those lines.

I agree. Will action and resolve in a PR soon.