Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python support for no content responses #1459

Closed
baywet opened this issue Mar 28, 2022 · 0 comments · Fixed by #1630 or #1500
Closed

Python support for no content responses #1459

baywet opened this issue Mar 28, 2022 · 0 comments · Fixed by #1630 or #1500
Assignees
@samwelkanda
Labels
enhancement New feature or request fixed Python
Milestone
Complete Graph AP...

Comments

@baywet
Copy link
Member

baywet commented Mar 28, 2022

See #1410 and #1457 for more context. The request adapter needs to do two things:

  • return null on a 204 response (even if a model is expected to be returned)
  • always purge the response content (read all content, close the response/content)
@baywet baywet added enhancement New feature or request Python labels Mar 28, 2022
@samwelkanda samwelkanda mentioned this issue Apr 28, 2022
Closed
2 tasks
@samwelkanda samwelkanda mentioned this issue Jun 15, 2022
Merged
1 task
@samwelkanda samwelkanda linked a pull request Jul 15, 2022 that will close this issue
Add support for no content responses #1630
Merged
1 task
@ghost ghost added the fixed label Jul 15, 2022
@baywet baywet linked a pull request Jul 15, 2022 that will close this issue
Feature/discriminator support python #1500
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samwelkanda samwelkanda

Labels
enhancement New feature or request fixed Python
Projects
None yet
Milestone
Complete Graph API Surface support
2 participants
@baywet @samwelkanda