Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby support for discriminator downcast during deserialization #1652

Closed
3 of 4 tasks
Tracked by #1049
baywet opened this issue Jun 23, 2022 · 0 comments · Fixed by #2106
Closed
3 of 4 tasks
Tracked by #1049

ruby support for discriminator downcast during deserialization #1652

baywet opened this issue Jun 23, 2022 · 0 comments · Fixed by #2106
Assignees
@baywet
Labels
enhancement New feature or request fixed Ruby
Milestone
Backlog

Comments

@baywet
Copy link
Member

baywet commented Jun 23, 2022 •
edited
Loading

details located in #648 and associated PR.

To deserialize to the right type we need to:

  • implement generating the discriminator static method for models (reads a property in the payload and instantiates the right type)
  • pass a reference to that method to the request adapter in the request executor method.
  • forward the reference to that method to the parse node in the request adapter
  • update the corresponding parse node, request adapter interfaces

Note: this is also impacted by ongoing work in #1411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baywet baywet

Labels
enhancement New feature or request fixed Ruby
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

- adds support for discriminator in ruby microsoft/kiota
2 participants
@baywet @osose-e