Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for escaped query parameter names in ruby #1664

Closed
Tracked by #1049
baywet opened this issue Jun 27, 2022 · 0 comments · Fixed by #2102
Closed
Tracked by #1049

support for escaped query parameter names in ruby #1664

baywet opened this issue Jun 27, 2022 · 0 comments · Fixed by #2102
Assignees
Labels
fixed Ruby type:bug A broken experience
Milestone

Comments

@baywet
Copy link
Member

baywet commented Jun 27, 2022

more details at #1445

Some query parameter names are escaped in the generated code because the are invalid symbol names in the target language (e.g. $select).

While this solves any compilation issues, it breaks the URL templating mechanism for escaped names (because the expected parameter name by the template engine will be %24select.
The ruby generation needs a way to carry that information so the template parameter matches the property name.

In other languages we've used annotations/attribute where the property is augmented by a custom attribute with the right property name the engine expects, and the add parameters method reads in that attribute if present instead of taking the property name.

Related to #1651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Ruby type:bug A broken experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants