Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default client name from GraphClient to ApiClient #189

Closed
darrelmiller opened this issue May 31, 2021 · 5 comments · Fixed by #199
Closed

Change the default client name from GraphClient to ApiClient #189

darrelmiller opened this issue May 31, 2021 · 5 comments · Fixed by #199
Assignees
@wcontayon
Labels
enhancement New feature or request help wanted Issue caused by core project dependency modules or library
Milestone
Alpha

Comments

@darrelmiller
Copy link
Member

darrelmiller commented May 31, 2021 •
edited
Loading

We should remove all traces of Graph from the default Kiota to that we can be sure we have all the necessary extension points.

  • Change client name from GraphClient to ApiClient
  • Change default namespace
  • Change default PathSegment. Should we make this a command line parameter?

AB#9644
@baywet baywet self-assigned this May 31, 2021
@baywet baywet added this to the Alpha milestone May 31, 2021
@baywet
Copy link
Member

baywet commented May 31, 2021

What do you mean by default path segment? For the directory Kiota writes things to?

@baywet baywet added the enhancement New feature or request label May 31, 2021
@wcontayon
Copy link

Hi @baywet @darrelmiller seems an interested issue. How can we contribute ?
Any insight will be welcomed 🙂

@baywet
Copy link
Member

baywet commented May 31, 2021

Hey @wcontayon
Thanks for reaching out and for offering your help.
The command line options are located here https://www.github.com/microsoft/kiota/tree/main/src%2Fkiota%2FKiotaHost.cs
Let me know if you need anything else.

@wcontayon
Copy link

Sure @baywet will submit a PR.

@baywet baywet added the help wanted Issue caused by core project dependency modules or library label Jun 1, 2021
@baywet baywet assigned wcontayon and unassigned baywet Jun 1, 2021
@baywet
Copy link
Member

baywet commented Jun 1, 2021

thanks! Also while I think about it, can you please update:

@wcontayon wcontayon mentioned this issue Jun 2, 2021
Merged
@baywet baywet linked a pull request Jun 2, 2021 that will close this issue
Change default client name GraphClient => ApiClient #199
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wcontayon wcontayon

Labels
enhancement New feature or request help wanted Issue caused by core project dependency modules or library
Projects
None yet
Milestone
Alpha
Development

Successfully merging a pull request may close this issue.

Change default client name GraphClient => ApiClient wcontayon/kiota
3 participants
@darrelmiller @baywet @wcontayon