Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Having server URLs in an OpenApi description should not be required for the show command #1896

Closed
darrelmiller opened this issue Oct 16, 2022 · 3 comments · Fixed by #1901
Closed

Having server URLs in an OpenApi description should not be required for the show command #1896

darrelmiller opened this issue Oct 16, 2022 · 3 comments · Fixed by #1901
Assignees
@baywet
Labels
enhancement New feature or request fixed generator Issues or improvements relater to generation capabilities.

Comments

@darrelmiller
Copy link
Member

image
@baywet
Copy link
Member

baywet commented Oct 16, 2022

It means people will have to set the URL manually. Should we at least warn?

@baywet baywet self-assigned this Oct 16, 2022
@baywet baywet added Needs: Author Feedback enhancement New feature or request generator Issues or improvements relater to generation capabilities. labels Oct 16, 2022
@baywet baywet added this to Kiota Oct 16, 2022
@baywet baywet moved this to Todo in Kiota Oct 16, 2022
@baywet baywet moved this from Todo to In Progress in Kiota Oct 17, 2022
@baywet baywet mentioned this issue Oct 17, 2022
Merged
@darrelmiller
Copy link
Member Author

They will get the error when they try to generate.

@baywet
Copy link
Member

baywet commented Oct 17, 2022

I'm all for failing as early as possible but I understand it's an opinion.
Replaced the exception by a warning in the generator.

@baywet baywet closed this as completed in ea8ac22 Oct 18, 2022
Repository owner moved this from In Progress to Done in Kiota Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baywet baywet

Labels
enhancement New feature or request fixed generator Issues or improvements relater to generation capabilities.
Projects
Kiota
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature/commands enhancements microsoft/kiota
2 participants
@darrelmiller @baywet