Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename createRequestInformation methods to improve auto-completion experience #2071

Closed
sebastienlevert opened this issue Dec 15, 2022 · 3 comments · Fixed by #2126
Closed
Assignees
Labels
Csharp Pull requests that update .net code enhancement New feature or request fixed generator Issues or improvements relater to generation capabilities. Go Java TypeScript Pull requests that update Javascript code
Milestone

Comments

@sebastienlevert
Copy link
Contributor

As a developer, I don't know what I would do with these methods and how it would help me build an app on Graph.

Should we make these methods private? Is there a reason why they are public?

image

@sebastienlevert sebastienlevert added the TypeScript Pull requests that update Javascript code label Dec 15, 2022
@baywet
Copy link
Member

baywet commented Dec 15, 2022

These methods are needed for things like batching. They are also super helpful to troubleshoot things when URL building, parameters, headers... Might be wrong.

@sebastienlevert
Copy link
Contributor Author

Hmmm... I can see how it can be used for batching... For URL building, I wouldn't consider it a must, but I get that it can be a tool for developers. I just feels weird when exploring an API that I see these methods all over the place. Might be more of a personal opinion, though.

@darrelmiller
Copy link
Member

Let's rename all these factory methods to have the "To" prefix to group them together and stop them from interfering with the main requestor methods.

  .ToGetRequestInformation()
  .ToPostRequestInformation()
  .ToPatchRequestInformation()
  etc.

@darrelmiller darrelmiller added generator Issues or improvements relater to generation capabilities. and removed Needs: Author Feedback labels Dec 16, 2022
@baywet baywet changed the title When generating request builders, createRequestInformation should be private rename createRequestInformation methods to improve auto-completion experience Dec 16, 2022
@baywet baywet added enhancement New feature or request Csharp Pull requests that update .net code Go Java and removed question labels Dec 16, 2022
@baywet baywet self-assigned this Dec 16, 2022
@baywet baywet added this to Kiota Dec 16, 2022
@baywet baywet moved this to Todo in Kiota Dec 16, 2022
@baywet baywet added this to the Kiota GA milestone Dec 16, 2022
@baywet baywet moved this from Todo to In Progress in Kiota Jan 9, 2023
@baywet baywet added the fixed label Jan 9, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kiota Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Csharp Pull requests that update .net code enhancement New feature or request fixed generator Issues or improvements relater to generation capabilities. Go Java TypeScript Pull requests that update Javascript code
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants