Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflicting properties are generated when symbols are removed from names #2869

Closed
papegaaij opened this issue Jul 7, 2023 · 1 comment · Fixed by #2870
Closed

Conflicting properties are generated when symbols are removed from names #2869

papegaaij opened this issue Jul 7, 2023 · 1 comment · Fixed by #2870
Assignees
@papegaaij
Labels
generator Issues or improvements relater to generation capabilities. type:bug A broken experience WIP
Milestone
Kiota v1.5

Comments

@papegaaij
Copy link
Contributor

papegaaij commented Jul 7, 2023 •
edited
Loading

This was addressed in #2836 but reverted in #2862 due to problems with race conditions and regressions in the integration tests. This issue is to track progress on rework of the code.
@papegaaij papegaaij mentioned this issue Jul 7, 2023
Merged
@papegaaij
Copy link
Contributor Author

@baywet I think I've managed to implement a working locking strategy in #2870. Together with #2861 and #2863, I was able to generate identical code for the Graph API in several subsequent runs. The code is also identical to the code generated with parallelism disabled. Performance seems not to be impacted in a noticeable way by this change.

In this PR I did have to disable parallelism on TrimInheritedModels to prevent that part from failing (which it does very frequently on my machine and hard with a stackdump). I do not believe those problems are related at all to the changes in the linked PR. I'll create a new ticket to track those issues.

@baywet baywet linked a pull request Jul 10, 2023 that will close this issue
Resolve property name conflicts second attempt #2870
Merged
@baywet baywet added this to the Kiota v1.5 milestone Jul 10, 2023
@baywet baywet added this to Kiota Jul 10, 2023
@github-project-automation github-project-automation bot moved this to Todo in Kiota Jul 10, 2023
@baywet baywet added type:bug A broken experience generator Issues or improvements relater to generation capabilities. labels Jul 10, 2023
@baywet baywet moved this from Todo to In Progress in Kiota Jul 10, 2023
@baywet baywet added the WIP label Jul 10, 2023
@baywet baywet mentioned this issue Jul 10, 2023
Closed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kiota Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@papegaaij papegaaij

Labels
generator Issues or improvements relater to generation capabilities. type:bug A broken experience WIP
Projects
Kiota
Archived in project
Milestone
Kiota v1.5
Development

Successfully merging a pull request may close this issue.

Resolve property name conflicts second attempt papegaaij/kiota
2 participants
@papegaaij @baywet