Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot enable backing store with visual studio extension #3355

Closed
ddyett opened this issue Sep 24, 2023 · 5 comments · Fixed by #3493
Closed

Cannot enable backing store with visual studio extension #3355

ddyett opened this issue Sep 24, 2023 · 5 comments · Fixed by #3493
Assignees
Labels
enhancement New feature or request vscode-extension Work related to the vscode-extension
Milestone

Comments

@ddyett
Copy link
Member

ddyett commented Sep 24, 2023

Goal was to test out dirty tracking in python, but generating from the extension always set the backing store value to false even if i update the kiota.lock file. I needed to manually update the kiota lock file, then run kiota update manually.

@darrelmiller
Copy link
Member

Yeah, we have run into a bit of a cyclical refresh issue with some recent changes where regenerating will overwrite settings you hand edited in the Kiota.lock file.

This will be addressed with the Kiota.config file that will cleanly separate user input vs what is output. I was writing the spec in a doc but I'm tired on not having good JSON editing abilities in word, so I'm just going to transfer it all to an issue here.

@baywet baywet self-assigned this Sep 25, 2023
@baywet baywet added enhancement New feature or request vscode-extension Work related to the vscode-extension labels Sep 25, 2023
@baywet baywet added this to the Kiota v1.8 milestone Sep 25, 2023
@baywet
Copy link
Member

baywet commented Oct 2, 2023

We have a number of settings that can't be passed through the generation dialog today.
But I don't feel like asking 12 questions during the generation would lead to a great experience.

We should probably register settings in vscode for those. They are defined by the user, sync across devices, and can be overridden by project.

Separately, when a lock is present, the extension should read/watch it before passing things back to the generator to avoid things set manually from being overwritten.

@baywet baywet moved this from Todo to In Progress in Kiota Oct 12, 2023
@baywet
Copy link
Member

baywet commented Oct 12, 2023

here is what the settings panel is starting to look like.

image

@sebastienlevert
Copy link
Contributor

Priority order of setting:

  1. kiota command line values (impacted by VS Code settings)
  2. kiota command line default values

@baywet
Copy link
Member

baywet commented Oct 13, 2023

implemented. To your original question DeVere:

  • things in kiota lock are always overwritten by what's in the vs code context (settings, answer to questions, default values for settings) during the generate commands.
  • things in kiota lock are kept during the update command.
  • you now have settings to set the backing store, etc...
  • those settings can be overridden by repo thanks to how vs code settings work in general.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Kiota Oct 19, 2023
@thewahome thewahome removed the WIP label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vscode-extension Work related to the vscode-extension
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants