Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python abstraction 0.9.0 is broken with current Kiota #3533

Closed
andreaTP opened this issue Oct 20, 2023 · 7 comments · Fixed by #3524
Closed

Python abstraction 0.9.0 is broken with current Kiota #3533

andreaTP opened this issue Oct 20, 2023 · 7 comments · Fixed by #3524
Assignees
Labels
Python type:bug A broken experience WIP
Milestone

Comments

@andreaTP
Copy link
Contributor

Using Kiota from main or the current preview release with microsoft-kiota-abstractions == 0.9.0 breaks the user code:

AttributeError: 'RequestInformation' object has no attribute 'try_add_request_header'
@andreaTP
Copy link
Contributor Author

The error can be easily reproduced by reverting the library version change in #3534

@baywet
Copy link
Member

baywet commented Oct 20, 2023

Hi @andreaTP
Thanks for reporting this. I believe we already have an outstanding PR to address this #3524, it's just that the abstractions are ahead of the generation a little at this point. Sorry about the disagreement, we're getting ready to move both PHP and Python to stable :)

@baywet baywet added type:bug A broken experience Python labels Oct 20, 2023
@baywet baywet linked a pull request Oct 20, 2023 that will close this issue
@baywet baywet added this to the Kiota v1.8 milestone Oct 20, 2023
@baywet baywet moved this from Todo to In Progress in Kiota Oct 20, 2023
@andreaTP
Copy link
Contributor Author

No worries, I was just reporting as the automation in Apicurio Registry correctly failed on those issues 👍

we're getting ready to move both PHP and Python to stable :)

🎉

@baywet
Copy link
Member

baywet commented Oct 20, 2023

are you taking kiota straight from the main branch or using a (pre) released version?

@andreaTP
Copy link
Contributor Author

Using only stable releases in downstream repos, but I tested that the bug was still present in the development branch.

@baywet
Copy link
Member

baywet commented Oct 20, 2023

ah so the preview of kiota we put out yesterday is also messed up on that aspect? good to know.

@andreaTP
Copy link
Contributor Author

not really, in this case, it broke because the Python library doesn't work anymore with the generated code.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Kiota Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python type:bug A broken experience WIP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants