Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python - not snake-casing some property names #3589

Closed
Ndiritu opened this issue Oct 26, 2023 · 2 comments · Fixed by #3598
Closed

Python - not snake-casing some property names #3589

Ndiritu opened this issue Oct 26, 2023 · 2 comments · Fixed by #3598
Assignees
Milestone

Comments

@Ndiritu
Copy link
Contributor

Ndiritu commented Oct 26, 2023

There's a few edge cases of properties in Graph models that are not snake cased correctly.

e.g.

@Ndiritu Ndiritu added the Python label Oct 26, 2023
@Ndiritu Ndiritu added this to the Kiota v1.8 milestone Oct 26, 2023
@Ndiritu Ndiritu added this to Kiota Oct 26, 2023
@github-project-automation github-project-automation bot moved this to Todo in Kiota Oct 26, 2023
@baywet
Copy link
Member

baywet commented Oct 26, 2023

In the case of externalcourse_activity_id, this is "normal" as the property is named "externalcourseActivityId" (notice the lowercased c) on the service.
For the others, I agree that we're missing some underscores. Especially when we consider that the casing is right in other languages

@sebastienlevert
Copy link
Contributor

Let's be careful as this would be a breaking change for future versions of the Graph SDK. @shemogumbe I feel this should be fixed before GA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants