Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigation for Proxy generation for Request Builders in TypeScript #3642

Closed
sebastienlevert opened this issue Nov 2, 2023 · 2 comments · Fixed by #3938
Closed

Investigation for Proxy generation for Request Builders in TypeScript #3642

sebastienlevert opened this issue Nov 2, 2023 · 2 comments · Fixed by #3938
Assignees
Labels
enhancement New feature or request TypeScript Pull requests that update Javascript code WIP
Milestone

Comments

@sebastienlevert
Copy link
Contributor

Explore the feasibility of generating a proxy-based service library for Kiota-generated clients.

@sebastienlevert sebastienlevert added this to the Kiota v1.9 milestone Nov 2, 2023
@github-project-automation github-project-automation bot moved this to Todo in Kiota Nov 2, 2023
@sebastienlevert sebastienlevert added the TypeScript Pull requests that update Javascript code label Nov 2, 2023
@baywet
Copy link
Member

baywet commented Nov 22, 2023

Add link to prior work https://github.com/patrick-rodgers/fhl-2023-fall

@baywet baywet modified the milestones: Kiota v1.9, Kiota v1.10 Dec 1, 2023
@baywet baywet moved this from Todo to In Progress in Kiota Dec 8, 2023
@baywet baywet added the enhancement New feature or request label Dec 8, 2023
@baywet baywet modified the milestones: Kiota v1.10, Kiota v1.11 Jan 11, 2024
@baywet
Copy link
Member

baywet commented Jan 11, 2024

If this doesn't yield enough tree shaking/size-reduction here are the options we might consider for Microsoft Graph:

  • selective import (impacts devx)
  • self-serve only (impacts discovery)
  • product centered packages (see below)

product centered packages:

  1. setup a mono-repo (lerna)
  2. main project is the models: full gen + script to remove anything besides reusable models
  3. other projects are sliced by surface area (we could use PowerShell's slicing): gen from those description + script that removes models and replaces imports (each client name needs to be different to allow multiple clients being used in the same context)
  4. success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request TypeScript Pull requests that update Javascript code WIP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants