Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Composed type wrapper model classes contain underscores #3824

Closed
andreaTP opened this issue Nov 28, 2023 · 5 comments · Fixed by #3939
Closed

[Java] Composed type wrapper model classes contain underscores #3824

andreaTP opened this issue Nov 28, 2023 · 5 comments · Fixed by #3939
Assignees
Labels
help wanted Issue caused by core project dependency modules or library Java type:bug A broken experience WIP
Milestone

Comments

@andreaTP
Copy link
Contributor

Haven't reduced it yet, but you can reproduce the issue with:

kiota generate --openapi https://raw.githubusercontent.com/openai/openai-openapi/master/openapi.yaml --output tmp --language java --clean-output true --clear-cache true

You get a successful output and that's great, unfortunately, there are static inner classes generated with names like: CreateImageRequest_model which should be CreateImageRequestModel instead.

@github-project-automation github-project-automation bot moved this to Todo in Kiota Nov 28, 2023
@baywet baywet added type:bug A broken experience help wanted Issue caused by core project dependency modules or library Java labels Nov 28, 2023
@baywet baywet added this to the Kiota v1.10 milestone Nov 28, 2023
@baywet
Copy link
Member

baywet commented Nov 28, 2023

Thanks for reporting this @andreaTP
Is this something you'd like to address?

@andreaTP
Copy link
Contributor Author

A bit low on the priority list ATM, but I might get to it eventually ... maybe better to assign someone else for now ...

@baywet
Copy link
Member

baywet commented Nov 28, 2023

I wish I could, but I simply don't have the bandwidth to do it myself. @ramsessanchez might have the time to handle this one, but he is heads down working on the Microsoft Graph Java GA for the time being.

@sebastienlevert
Copy link
Contributor

@baywet, does that impact Java SDK for Graph GA? If this might include some levels of breaking changes, it might be worth having a look.

@baywet
Copy link
Member

baywet commented Nov 28, 2023

Microsoft Graph doesn't make use of composed types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issue caused by core project dependency modules or library Java type:bug A broken experience WIP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants