Endpoints with difference only in return types are resulting in error for C# generator

[derigel23]

I have an OpenAPI specification for TeamCity.
For example, here https://teamcity.jetbrains.com/guestAuth/app/rest/swagger.json

It compiles with error.
WithPathRequestBuilder.cs(60, 40): [CS0111] Type 'WithPathRequestBuilder' already defines a member called 'GetAsync' with the same parameter types.
Generated C# code is not valid:

        /// <summary>
        /// Get specific file zipped.
        /// </summary>
        /// <returns>A <see cref="Stream"/></returns>
        /// <param name="cancellationToken">Cancellation token to use when cancelling requests</param>
        /// <param name="requestConfiguration">Configuration for the request such as headers, query parameters, and middleware options.</param>
        public async Task<Stream?> GetAsync(Action<RequestConfiguration<WithPathRequestBuilderGetQueryParameters>>? requestConfiguration = default, CancellationToken cancellationToken = default)
        {
            var requestInfo = ToGetRequestInformation(requestConfiguration);
            return await RequestAdapter.SendPrimitiveAsync<Stream>(requestInfo, default, cancellationToken).ConfigureAwait(false);
        }
        /// <summary>
        /// Get metadata of specific file.
        /// </summary>
        /// <returns>A <see cref="FileObject"/></returns>
        /// <param name="cancellationToken">Cancellation token to use when cancelling requests</param>
        /// <param name="requestConfiguration">Configuration for the request such as headers, query parameters, and middleware options.</param>
        public async Task<FileObject?> GetAsync(Action<RequestConfiguration<WithPathRequestBuilderGetQueryParameters>>? requestConfiguration = default, CancellationToken cancellationToken = default)
        {
            var requestInfo = ToGetRequestInformation(requestConfiguration);
            return await RequestAdapter.SendAsync<FileObject>(requestInfo, FileObject.CreateFromDiscriminatorValue, default, cancellationToken).ConfigureAwait(false);
        }

C# can't have overloads with difference only in return type,

[baywet]

Hi @derigel23
Thanks for using kiota, for reaching out and for your patience.
Can you share which operation/path item is this code snippet for please?
This is most likely cause by a limitation of the generator we have today. See #2317

[derigel23]

Hi @baywet
It seems not my case - I do not have several results for one operation.
I do have several different operations but with the same suffix parameter.
For example
/app/rest/buildTypes/{btLocator}/vcs/files/latest/metadata{path}
/app/rest/buildTypes/{btLocator}/vcs/files/latest/{path}
And that suffix parameter get reused in WithPathRequestBuilderGetQueryParameters but applying it to different paths will result in different result type.

[andrueastman]

The error here looks to be caused by paths in the descriptions that end up having conflicting request builders.

The following paths end up being resolved to the same request builder by kiota with the name WithPathRequestBuilder. The naming doesn't take the prefix before the indexer into account causing the conflict.

This ends up adding multiple executors to the same class.

/app/rest/server/files/{areaId}/metadata{path}
/app/rest/server/files/{areaId}/{path}
/app/rest/server/files/{areaId}/archived{path}
/app/rest/server/files/{areaId}/files{path}

The metadata{path} and {path} segments end up being mapped to the same request builder rather two separate ones.

The culprit looks to be

kiota/src/Kiota.Builder/Extensions/OpenApiUrlTreeNodeExtensions.cs

Line 55 in e74b1d0

private static string CleanupParametersFromPath(string pathSegment)

whose Regex doesn't seem to cater for such a case.

kiota/src/Kiota.Builder/Extensions/OpenApiUrlTreeNodeExtensions.cs

Line 43 in e74b1d0

[GeneratedRegex(@"(?:\w+)?=?'?\{(?<paramName>\w+)\}'?,?", RegexOptions.Singleline, 500)]

[andrueastman]

Authored #4517 to resolve.