Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api manifests should not contain a kiota hash #4561

Closed
baywet opened this issue Apr 26, 2024 · 0 comments · Fixed by #4567
Closed

api manifests should not contain a kiota hash #4561

baywet opened this issue Apr 26, 2024 · 0 comments · Fixed by #4567
Assignees
Labels
generator Issues or improvements relater to generation capabilities. priority:p1 High priority/Major issue but not blocking or Big percentage of customers affected.Bug SLA <=7days type:bug A broken experience
Milestone

Comments

@baywet
Copy link
Member

baywet commented Apr 26, 2024

When I generate an API manifest I get the following result

{
  "applicationName": "application",
  "apiDependencies": {
    "github": {
      "apiDescriptionUrl": "https://raw.githubusercontent.com/APIs-guru/openapi-directory/gh-pages/v2/specs/github.com/api.github.com/1.1.4/openapi.json",
      "apiDeploymentBaseUrl": "https://api.github.com/",
      "requests": [
        {
          "method": "POST",
          "uriTemplate": "markdown"
        }
      ],
      "extensions": {
        "x-ms-kiota-hash": "75936866893F983D9B8E247A93D0F2DBE4F5B1CE4CC76EB85FEF8AE46B1791F7F130ACCF202043576645EBC8D3E2E6F2E76768F42FCC58945286D775253380C8"
      }
    }
  }
}

notice that it contains an extension with the kiota hash.
This is caused because we need that kiota hash in the kiota manifest for the workspace, which we need/should keep. However it should not be in the plugin manifest.

@baywet baywet added type:bug A broken experience generator Issues or improvements relater to generation capabilities. priority:p1 High priority/Major issue but not blocking or Big percentage of customers affected.Bug SLA <=7days labels Apr 26, 2024
@baywet baywet added this to the Kiota v1.14 milestone Apr 26, 2024
@baywet baywet added this to Kiota Apr 26, 2024
@github-project-automation github-project-automation bot moved this to Todo 📃 in Kiota Apr 26, 2024
@andrueastman andrueastman self-assigned this Apr 29, 2024
@github-project-automation github-project-automation bot moved this from Todo 📃 to Done ✔️ in Kiota Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generator Issues or improvements relater to generation capabilities. priority:p1 High priority/Major issue but not blocking or Big percentage of customers affected.Bug SLA <=7days type:bug A broken experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants