Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate of exporting the CodeDom to standardised file. #4627

Closed
andrueastman opened this issue May 8, 2024 · 2 comments · Fixed by #5085
Closed

Investigate of exporting the CodeDom to standardised file. #4627

andrueastman opened this issue May 8, 2024 · 2 comments · Fixed by #5085
Assignees
Labels
type:feature New experience request type:investigation Investigation work, output should be a document detailing findings or a prototype WIP

Comments

@andrueastman
Copy link
Member

Is your feature request related to a problem? Please describe the problem.

Capture regressions in a consistent fashion much earlier.

Client library/SDK language

None

Describe the solution you'd like

Exporting the CodeDom to a file (which would then be diffed or compared with a tool)would possibly unlock the detections of generation regressions that may result in breaking changes in the following scenarios.

  • Metadata - removal of paths/types
  • Naming changes that are breaking
  • Multiple/repeated validations across languages as the dom could optionally be exported before or after the refiner.

Additional context

No response

@andrueastman andrueastman added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request labels May 8, 2024
@msgraph-bot msgraph-bot bot added this to Kiota May 8, 2024
@github-project-automation github-project-automation bot moved this to Todo 📃 in Kiota May 8, 2024
@baywet
Copy link
Member

baywet commented May 8, 2024

Thanks for creating the issue.
Adding some thoughts:
Since that export is going to be read by tools, it probably needs to have a JSON schema associated with it.
I don't think the export should be systematic to begin with, maybe let's hide that behind an environment variable at first?
It should NOT contain descriptions or deprecation information.

@fey101
Copy link
Contributor

fey101 commented May 8, 2024

Relates to #4628

@baywet baywet self-assigned this May 9, 2024
@andrueastman andrueastman added type:investigation Investigation work, output should be a document detailing findings or a prototype and removed status:waiting-for-triage An issue that is yet to be reviewed or assigned labels Jul 4, 2024
@baywet baywet moved this from Todo 📃 to In Progress 🚧 in Kiota Jul 23, 2024
@andrueastman andrueastman self-assigned this Aug 27, 2024
@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✔️ in Kiota Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New experience request type:investigation Investigation work, output should be a document detailing findings or a prototype WIP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants