Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing UntypedNode import in Java, in various places #5326

Closed
andreaTP opened this issue Sep 4, 2024 · 4 comments · Fixed by #5327
Closed

missing UntypedNode import in Java, in various places #5326

andreaTP opened this issue Sep 4, 2024 · 4 comments · Fixed by #5327
Labels
Csharp Pull requests that update .net code Go Java type:bug A broken experience WIP
Milestone

Comments

@andreaTP
Copy link
Contributor

andreaTP commented Sep 4, 2024

What are you generating using Kiota, clients or plugins?

API Client/SDK

In what context or format are you using Kiota?

Linux executable

Client library/SDK language

Java

Describe the bug

import com.microsoft.kiota.serialization.UntypedNode is not present in some files where UntypedNode is used.

Expected behavior

import com.microsoft.kiota.serialization.UntypedNode should be present every time that is used in the generated code.

How to reproduce

Running this command:

kiota generate -d https://storage.googleapis.com/libpod-master-releases/swagger-latest.yaml -o ./tmp --language Java

Open API description file

No response

Kiota Version

1.17.0

Latest Kiota version known to work for scenario above?(Not required)

1.13.0

Known Workarounds

No response

Configuration

No response

Debug output

Click to expand log ```
</details>


### Other information

_No response_
@andreaTP andreaTP added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:bug A broken experience labels Sep 4, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Sep 4, 2024
@msgraph-bot msgraph-bot bot added the Java label Sep 4, 2024
@baywet
Copy link
Member

baywet commented Sep 4, 2024

Hi @andreaTP
Can you share the version of the kiota dependencies used by your application please?

@baywet baywet added status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close type:question An issue that's a question and removed type:bug A broken experience status:waiting-for-triage An issue that is yet to be reviewed or assigned labels Sep 4, 2024
@baywet baywet moved this from Needs Triage 🔍 to Waits for author 🔁 in Kiota Sep 4, 2024
@andreaTP
Copy link
Contributor Author

andreaTP commented Sep 4, 2024

@baywet 1.3.0 but is irrelevant as the issue is that the import statement is missing in generated code.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 and removed status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close labels Sep 4, 2024
@baywet baywet moved this from Waits for author 🔁 to In Review 💭 in Kiota Sep 4, 2024
@baywet baywet added type:bug A broken experience Csharp Pull requests that update .net code Go and removed WIP Needs: Attention 👋 type:question An issue that's a question labels Sep 4, 2024
@baywet baywet added this to the Kiota v1.18 milestone Sep 4, 2024
@baywet
Copy link
Member

baywet commented Sep 4, 2024

Thank you for the additional information.
I had read your initial post a bit too fast.
Authored #5327 to address the issue.
Let us know if you have any additional comments or questions.

@github-project-automation github-project-automation bot moved this from In Review 💭 to Done ✔️ in Kiota Sep 4, 2024
@andreaTP
Copy link
Contributor Author

andreaTP commented Sep 4, 2024

Thanks for the super quick resolution of the issue! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Csharp Pull requests that update .net code Go Java type:bug A broken experience WIP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants