Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaping Item keywords in request builders also escapes unrelated request builder properties. #5433

Closed
andrueastman opened this issue Sep 18, 2024 · 0 comments · Fixed by #5434
Assignees
Labels
Csharp Pull requests that update .net code type:bug A broken experience WIP
Milestone

Comments

@andrueastman
Copy link
Member

What are you generating using Kiota, clients or plugins?

API Client/SDK

In what context or format are you using Kiota?

Source Build

Client library/SDK language

Csharp

Describe the bug

Related to #4814

The escaping of requestBuilder properties causes the escpaing of unrelated builders such as DriveItemRequestBuilder becoming DriveItem_EscapedRequestBuilder.

The check should probably not use endsWith at

if (child.Path.EndsWith(OpenApiUrlTreeNodeExtensions.ReservedItemName, StringComparison.OrdinalIgnoreCase))

as it causing failing compilation at
microsoftgraph/msgraph-sdk-java#2161 and related PRs in other languages.

Expected behavior

  • Non breaking change
  • Passing compilation

How to reproduce

Run Kiota on latest head of main branch and with latest MS graph metadata.

Open API description file

No response

Kiota Version

main

Latest Kiota version known to work for scenario above?(Not required)

No response

Known Workarounds

No response

Configuration

No response

Debug output

Click to expand log ```
</details>


### Other information

_No response_
@andrueastman andrueastman added type:bug A broken experience status:waiting-for-triage An issue that is yet to be reviewed or assigned labels Sep 18, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Sep 18, 2024
@andrueastman andrueastman removed the status:waiting-for-triage An issue that is yet to be reviewed or assigned label Sep 18, 2024
@msgraph-bot msgraph-bot bot added the Csharp Pull requests that update .net code label Sep 18, 2024
@andrueastman andrueastman self-assigned this Sep 18, 2024
@andrueastman andrueastman moved this from Needs Triage 🔍 to Todo 📃 in Kiota Sep 18, 2024
@andrueastman andrueastman added this to the Kiota v1.18.1 milestone Sep 18, 2024
@github-project-automation github-project-automation bot moved this from Todo 📃 to Done ✔️ in Kiota Sep 18, 2024
@baywet baywet modified the milestones: Kiota v1.18.1, Kiota v1.19 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Csharp Pull requests that update .net code type:bug A broken experience WIP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants