Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP - doc comments with */ lead to invalid code #5635

Closed
baywet opened this issue Oct 18, 2024 · 0 comments · Fixed by #5770
Closed

PHP - doc comments with */ lead to invalid code #5635

baywet opened this issue Oct 18, 2024 · 0 comments · Fixed by #5770
Assignees
@timayabi2020
Labels
PHP type:bug A broken experience type:regression A bug from previous release WIP
Milestone
Kiota v1.21

Comments

@baywet
Copy link
Member

baywet commented Oct 18, 2024 •
edited
Loading 

kiota generate -d https://raw.githubusercontent.com/APIs-guru/openapi-directory/gh-pages/v2/specs/github.com/api.github.com/1.1.4/openapi.json -l PHP

and attempting to build the client leads to

 ------ ------------------------------------------------------------ 
  Line   client/Models/CodeScanningAlertDismissedReason.php          
 ------ ------------------------------------------------------------ 
  9      Syntax error, unexpected T_STRING, expecting ';' on line 9  
 ------ ------------------------------------------------------------ 

 ------ ----------------------------------------------------- 
  Line   client/Models/DeploymentBranchPolicyNamePattern.php  
 ------ ----------------------------------------------------- 
  18     Syntax error, unexpected '*' on line 18              
  83     Syntax error, unexpected '*' on line 83              
 ------ -----------------------------------------------------

This is caused by the presence of */ in the doc comment. Removing the value fixes the problem. It should be escaped.
@baywet baywet added PHP type:bug A broken experience type:regression A bug from previous release labels Oct 18, 2024
@baywet baywet added this to Kiota Oct 18, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Oct 18, 2024
@baywet baywet moved this from Needs Triage 🔍 to Todo 📃 in Kiota Oct 18, 2024
@timayabi2020 timayabi2020 self-assigned this Oct 24, 2024
@timayabi2020 timayabi2020 moved this from Todo 📃 to In Progress 🚧 in Kiota Nov 7, 2024
@timayabi2020 timayabi2020 mentioned this issue Nov 13, 2024
Merged
@timayabi2020 timayabi2020 linked a pull request Nov 13, 2024 that will close this issue
Fixes invalid code in Php caused by /*/*` in property description #5770
Merged
@timayabi2020 timayabi2020 moved this from In Progress 🚧 to In Review 💭 in Kiota Nov 13, 2024
@github-project-automation github-project-automation bot moved this from In Review 💭 to Done ✔️ in Kiota Nov 14, 2024
@baywet baywet added this to the Kiota v1.21 milestone Dec 5, 2024
@BrewTestBot BrewTestBot mentioned this issue Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timayabi2020 timayabi2020

Labels
PHP type:bug A broken experience type:regression A bug from previous release WIP
Projects
Kiota
Archived in project
Milestone
Kiota v1.21
Development

Successfully merging a pull request may close this issue.

Fixes invalid code in Php caused by /*/*` in property description microsoft/kiota
2 participants
@baywet @timayabi2020