From e9b546ac1c5d50dedb74764dc65a33f08ad467c5 Mon Sep 17 00:00:00 2001 From: Salman Shaikh Date: Thu, 13 Jul 2023 00:02:05 +0530 Subject: [PATCH 1/2] fix: updated `getEnumValues` method name to `getCollectionOfEnumValues` --- src/Kiota.Builder/Writers/TypeScript/CodeFunctionWriter.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Kiota.Builder/Writers/TypeScript/CodeFunctionWriter.cs b/src/Kiota.Builder/Writers/TypeScript/CodeFunctionWriter.cs index 88ebc339fd..dce365fcf8 100644 --- a/src/Kiota.Builder/Writers/TypeScript/CodeFunctionWriter.cs +++ b/src/Kiota.Builder/Writers/TypeScript/CodeFunctionWriter.cs @@ -205,7 +205,7 @@ private string GetDeserializationMethodName(CodeTypeBase propType, CodeFunction if (!string.IsNullOrEmpty(propertyType) && propType is CodeType currentType) { if (currentType.TypeDefinition is CodeEnum currentEnum) - return $"getEnumValue{(currentEnum.Flags || isCollection ? "s" : string.Empty)}<{currentEnum.Name.ToFirstCharacterUpperCase()}>({propertyType.ToFirstCharacterUpperCase()})"; + return $"{(currentEnum.Flags || isCollection ? "getCollectionOfEnumValues" : "getEnumValue")}<{currentEnum.Name.ToFirstCharacterUpperCase()}>({propertyType.ToFirstCharacterUpperCase()})"; else if (isCollection) if (currentType.TypeDefinition == null) return $"getCollectionOfPrimitiveValues<{propertyType}>()"; From e8f9bd7fbff3ead8a715a01f532d58f34e60bc98 Mon Sep 17 00:00:00 2001 From: Salman Shaikh Date: Thu, 13 Jul 2023 00:15:43 +0530 Subject: [PATCH 2/2] chore: updated CHANGELOG.md --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d2a23b51c4..b29c453150 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fixed missing type comments in many cases. - Use schematized types for 206 response codes instead of binary. [#2880](https://github.com/microsoft/kiota/issues/2880) - Typenames are not changed to first char upper case in comments in some cases. +- Updated `getEnumValues` method name to `getCollectionOfEnumValues`. [#2907](https://github.com/microsoft/kiota/pull/2907) + ## [1.4.0] - 2023-07-07