Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec for new CompletionItem field #514

Closed
MikhailArkhipov opened this issue Jul 4, 2018 · 2 comments
Closed

Update spec for new CompletionItem field #514

MikhailArkhipov opened this issue Jul 4, 2018 · 2 comments

Comments

@MikhailArkhipov
Copy link

MikhailArkhipov commented Jul 4, 2018

New 'preselect' field in the ls.CompletionItem.

Per microsoft/vscode-languageserver-node#371

and

microsoft/vscode#35551
microsoft/vscode@62e0f34

The feature added recently to VSC (1.25) allows completion provider to specify which item should be initially selected in the completion list. By default clients usually select first or last used items, which is limiting. A completion provider may choose to select different item based on other conditions, such as current code editor context, probability of use of certain items, and so on.

This request is to add equivalent field to the CompletionItem structure therefore allowing use of preselection in VS Code from language servers as it is possible from the regular completion provider.

@KamasamaK
Copy link
Contributor

This was resolved by #515

@dbaeumer
Copy link
Member

@KamasamaK correct. Closing the item.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants