Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce CodeLens notification message: ‘textDocument/publishCodeLenses’ #557

Closed
BoykoAlex opened this issue Aug 27, 2018 · 3 comments

Comments

@BoykoAlex
Copy link

It'd be great if ‘textDocument/codeLens’ message was a notification rather than request/response type of message. Push model might be better than pull model. Suppose CodeLens info is coming from a third-party process, i.e. a running application. Hence, trigger to pull new CodeLenses is out of control really...

Think ‘textDocument/publishCodeLenses’ notification message would be great and more versatile than the request/response message. Any chance this message can be introduced? Perhaps along with the request/response message rather than instead of it?

@martinlippert
Copy link

The use case for this on our end is a code lens that could appear and change over time.

@dbaeumer
Copy link
Member

What we need to introduce is a codeLens change notification from the server to the client so that the client can re-pull.

From the experiences we have so far a pull model from the client to the server superior especially since the client can decided when it is the best time to pull (consider a tab goes to the background and has stale code lens information. The client can postpone the pull until the tag gets visible again). And the client could include view port information to only compute necessary parts. It puts a little bit more management code onto the server but overall we found it the better strategy.

@dbaeumer
Copy link
Member

Actually dups: #358

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants