Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP does not prohibit empty symbol names, but VS Code rejects them #641

Closed
tchebb opened this issue Dec 17, 2018 · 1 comment
Closed

LSP does not prohibit empty symbol names, but VS Code rejects them #641

tchebb opened this issue Dec 17, 2018 · 1 comment
Labels
clarification
Milestone
3.16

Comments

@tchebb
Copy link

tchebb commented Dec 17, 2018

DocumentSymbol and SymbolInformation each hold a name field, defined only as a string that is "The name of this symbol." However, VS Code applies an additional constraint that the symbol name not be empty. This ambiguity recently caused the Rust Language Server to fail to populate VS Code's outline view (see rust-lang/rls#1193). If empty symbol names are actually prohibited, can the LSP spec reflect that?
@tchebb tchebb mentioned this issue Dec 17, 2018
Merged
@dbaeumer dbaeumer added this to the On Deck milestone Oct 31, 2019
@dbaeumer dbaeumer modified the milestones: On Deck, 3.16 Nov 10, 2020
@dbaeumer
Copy link
Member

dbaeumer commented Nov 12, 2020 •
edited
Loading

This got addressed in the 3.15 spec thanks to your PR.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
clarification
Projects
None yet
Milestone
3.16
Development

No branches or pull requests
2 participants
@tchebb @dbaeumer