Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request : textDocument/inlinedAnnotation #745

Closed
angelozerr opened this issue May 10, 2019 · 2 comments
Closed

Feature request : textDocument/inlinedAnnotation #745

angelozerr opened this issue May 10, 2019 · 2 comments
Labels
feature-request Request for new features or functionality

Comments

@angelozerr
Copy link
Contributor

I create this issue according my skills with Eclipse CodeMining which does the same thing than CodeLens but gives too the capability to draw content inside the line content (like color information used by CSS and JSON LS)

Takes a sample with Eclipse CodeMining:

  • here a CodeMining for JUnit: it is drawn by a line header annotation with an icon and text

image

  • here a CodeMining for parameter names for Java method: it is drawn by a line content annotation:

image

In other words I tell me if LSP could mix CodeLens and ColorInformation inside the same concept that it is called Inlined Annotation in Eclipse Platform.

Today LSP provides capabilities to support:

  • code lens which is drawn before the line text (line header annotation).
  • color information which is drawn in the line text (line content annotation)

IMHO, I think we could improve

  • CodeLens to specify an icon (or emoji)
  • Having a more generic concept than ColorInformation to draw anything in the line content annotation.

We could have an inlined annotation composted by:

  • text
  • icon (image name, or rgb color)
  • type : header (annotation drawn in the line header) or content (annotation drawn in the line content)

Here Inlined annotation benefit:

  • havejust one concept to manage CodeLens and ColorInformation both
  • improve CodeLens to draw an icon before the text
  • gives the capability to draw text/icon inside the line content (support for ColorInformation and other features like parameter names for Java method)
@dbaeumer dbaeumer added the feature-request Request for new features or functionality label Oct 31, 2019
@dbaeumer dbaeumer added this to the Backlog milestone Oct 31, 2019
@mickaelistria
Copy link

Couldn't we just generalize codelens response message to add some "insertionType: header | inline" ?

@dbaeumer
Copy link
Member

Dups #956

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 26, 2020
@dbaeumer dbaeumer removed this from the Backlog milestone Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants