Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very short missions can break the server state machine #23

Closed
timhutton opened this issue May 20, 2016 · 1 comment · Fixed by #119
Closed

Very short missions can break the server state machine #23

timhutton opened this issue May 20, 2016 · 1 comment · Fixed by #119
Labels
Milestone

Comments

@timhutton
Copy link
Contributor

When this happens the clients must be restarted.

@timhutton timhutton added bug P2 and removed bug labels May 20, 2016
@katja-hofmann katja-hofmann modified the milestone: Bison Jun 7, 2016
@timhutton timhutton added P3 and removed P2 labels Jun 27, 2016
@DaveyBiggers DaveyBiggers added P2 and removed P3 labels Jun 28, 2016
@DaveyBiggers DaveyBiggers changed the title Large render distance can break the server state machine Very short missions can break the server state machine Jun 28, 2016
@DaveyBiggers
Copy link
Member

For example, to reproduce, create a mission where the agent quits when reaching a goal, and set the agent's initial position to be on that goal square.

Why it goes wrong:

  1. The server waits until all clients are running before it starts running itself.
  2. Once the server is running, it listens out for mission-ended messages from the clients.
  3. Once it gets one, it ends the mission (if ServerQuitWhenAnyAgentQuits is specified, eg.)

In between 1) and 2), the client can finish the mission and send the mission-ended message, and the server will miss it. In such cases, the server may never declare the mission over, and the Minecraft instance may need to be restarted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants