Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate build battle mod code #337

Closed
DaveyBiggers opened this issue Sep 12, 2016 · 4 comments · Fixed by #375
Closed

Integrate build battle mod code #337

DaveyBiggers opened this issue Sep 12, 2016 · 4 comments · Fixed by #375
Labels
Milestone

Comments

@DaveyBiggers
Copy link
Member

No description provided.

@DaveyBiggers DaveyBiggers added this to the Fallow Deer milestone Sep 12, 2016
@salaniz
Copy link

salaniz commented Sep 29, 2016

I have implemented the build battle code in my Malmo installation, however the BlockEvents do not seem to trigger correctly. It uses PlaceEvent and BreakEvent and I can get it to work when I use the "Human Action Component" by issuing the commands myself. Once I let my agent perform the actions use 1 and attack 1 (I use the discrete actions), the events do not seem to trigger and I get no reward. Likewise, since the BlockEvents aren't triggered in agent mode, the agent is able to destroy and place blocks outside the building area whereas I, using the HAC, cannot.

It seems to me that this is an issue with (discrete) actions handled by Malmo, so it might be relevant to #301. I am not sure, though.

@DaveyBiggers
Copy link
Member Author

@salaniz - I've just created a PR (#375) with some updated build battle code, based on @geekstor's original code. It's not been thoroughly tested yet but hopefully it will resolve the issues you mention. (Though building outside the build area is currently allowed, provided it's not within the specified original area.)

@salaniz
Copy link

salaniz commented Oct 4, 2016

@DaveyBiggers, @geekstor - thanks a lot for the code and the PR! Unfortunately, this code does not resolve my issue. The problem persists that I am getting the reward in HAC mode, but not in agent mode.

Does anyone of you have a running example that it works with?

@salaniz
Copy link

salaniz commented Oct 11, 2016

@DaveyBiggers I checked out your latest commits for the build battle code. Thanks a lot for the work you put in. The build battle code fixed my problem now. Frankly, I think I didn't test against my problem thoroughly enough on the initial PR code so ignore my previous comment.

The code helps a lot and the example is amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants