Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbsoluteMovementCommands can cause problems with chunk loading #353

Closed
DaveyBiggers opened this issue Sep 15, 2016 · 5 comments
Closed

AbsoluteMovementCommands can cause problems with chunk loading #353

DaveyBiggers opened this issue Sep 15, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@DaveyBiggers
Copy link
Member

Similar issues to #195 can occur if an agent is teleported to a chunk that hasn't yet been loaded.
This seems to be an issue in vanilla Minecraft too - eg using the "tp" slash command can produce the same behaviour.

In addition, the game can get into a state where the player is stuck in an empty chunk (nothing but blue and empty sky), and the chunks never get loaded. Not sure if this ever happens in vanilla Minecraft.

@DaveyBiggers DaveyBiggers added this to the Fallow Deer milestone Sep 16, 2016
@DaveyBiggers DaveyBiggers self-assigned this Sep 16, 2016
@DaveyBiggers DaveyBiggers added P1 and removed P3 labels Sep 19, 2016
@DaveyBiggers
Copy link
Member Author

Am upping this to a P1, since teleporting a large distance (say, 1000 blocks away) can break chunk-loading entirely, leaving the player stuck in an empty chunk, with no fix other than to quit the game and reload.

@DaveyBiggers
Copy link
Member Author

image

Been staring at this for a while now. Have turned to Twin Peaks for inspiration. Seldom has a song title fitted a bug so perfectly:

https://www.youtube.com/watch?v=jdb9BTYIXkM

@Bloodknight
Copy link
Contributor

I have witnessed this issue in vanilla minecraft before, usually on initial load, but did also happen once when i died.

@DaveyBiggers
Copy link
Member Author

I've also seen similar things in vanilla minecraft, but never as reliably reproducible as this.
I think I've found the issue though - we were calling some server-side code from a netty server thread, rather than from the actual server thread. This was then loading chunks, and, I guess, ownership of the chunks was ending up on the wrong thread, causing mayhem and misery and the urge to listen to Julee Cruise albums. I will check in a fix once it's been thoroughly tested.

@DaveyBiggers
Copy link
Member Author

Closed by PR #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants