From 05a0b06d8bfec98f2a968b81d70f82a1f218ec7c Mon Sep 17 00:00:00 2001 From: Marcel Wagner Date: Wed, 2 Mar 2022 21:01:24 +0100 Subject: [PATCH] Make NavigationView SettingsItem Tag not localized (#6769) --- dev/NavigationView/NavigationView.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dev/NavigationView/NavigationView.cpp b/dev/NavigationView/NavigationView.cpp index f76f5ac1b2..3cafecb6b4 100644 --- a/dev/NavigationView/NavigationView.cpp +++ b/dev/NavigationView/NavigationView.cpp @@ -53,6 +53,7 @@ static constexpr auto c_navViewCloseButton = L"NavigationViewCloseButton"sv; static constexpr auto c_navViewCloseButtonToolTip = L"NavigationViewCloseButtonToolTip"sv; static constexpr auto c_paneShadowReceiverCanvas = L"PaneShadowReceiver"sv; static constexpr auto c_flyoutRootGrid = L"FlyoutRootGrid"sv; +static constexpr auto c_settingsItemTag = L"Settings"sv; // DisplayMode Top specific items static constexpr auto c_topNavMenuItemsHost = L"TopNavMenuItemsHost"sv; @@ -1317,7 +1318,7 @@ void NavigationView::CreateAndHookEventsToSettings() // Do localization for settings item label and Automation Name auto localizedSettingsName = ResourceAccessor::GetLocalizedStringResource(SR_SettingsButtonName); winrt::AutomationProperties::SetName(settingsItem, localizedSettingsName); - settingsItem.Tag(box_value(localizedSettingsName)); + settingsItem.Tag(box_value(c_settingsItemTag)); UpdateSettingsItemToolTip(); // Add the name only in case of horizontal nav