Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unquoted variables in packagize.sh #970

Closed
ilyash-b opened this issue Apr 10, 2019 · 2 comments
Closed

Unquoted variables in packagize.sh #970

ilyash-b opened this issue Apr 10, 2019 · 2 comments

Comments

@ilyash-b
Copy link

ilyash-b commented Apr 10, 2019 •
edited
Loading

https://github.com/Microsoft/msphpsql/blob/3ba26932d8c835080de305c35c79035f3efa593f/source/packagize.sh#L3-L10

$PWD that will contain spaces will cause issues

See When to wrap quotes around a shell variable? - Stack Overflow
@yitam
Copy link
Contributor

yitam commented Apr 10, 2019

Thanks @ilyash-b for bringing this to our attention.

@yitam yitam mentioned this issue Apr 15, 2019
Merged
@david-puglielli
Copy link
Contributor

Closing issue as it has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@david-puglielli @yitam @ilyash-b