Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Async Receive Path Testing #1383

Closed
nibanks opened this issue Mar 26, 2021 · 0 comments · Fixed by #1576
Closed

Improve Async Receive Path Testing #1383

nibanks opened this issue Mar 26, 2021 · 0 comments · Fixed by #1576
Labels
Area: Testing Related to test coverage good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@nibanks
Copy link
Member

nibanks commented Mar 26, 2021

Describe the bug

Testing of the async receive path needs improvement. For one, there's no test to ensure that a slow receiver still works when the sender gracefully shuts the stream down. For instance:

[Sender]
Open unidirectional stream.
Send X bytes.
Shutdown graceful.

[Receiver]
Receive new stream.
Receive data on stream. Return pending.
Wait a little while.
Complete receive (maybe partially?)
Get peer shutdown stream event.
Get shutdown complete stream event.

See #1384 for more details.

@nibanks nibanks added good first issue Good for newcomers help wanted Extra attention is needed Area: Testing Related to test coverage labels Mar 26, 2021
@nibanks nibanks added this to the Future milestone Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Related to test coverage good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant