Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configure db script #834

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dgenezini
Copy link

@dgenezini dgenezini commented May 8, 2023

The configure.db file is referenced in the Docker Hub documentation but does not work.

Fixes:

  • Variable i was being concatenated instead of incremented, making the script not wait for SQL Server to boot;
  • Ignoring errors from the select SUM(state) from sys.databases command;
  • Changed SA_PASSWORD variable to MSSQL_SA_PASSWORD (The correct one);
  • Removed chmod from Dockerfile.

Improvements:

  • Configurable number of retries;
  • Explicit unit of time (seconds) on the sleep command;

@dgenezini
Copy link
Author

@dgenezini please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@esdrasbeleza
Copy link

I had exactly the same issues and this PR fixed them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants