Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard in import statements #2

Closed
iamatinkerer opened this issue Nov 14, 2016 · 5 comments
Closed

Wildcard in import statements #2

iamatinkerer opened this issue Nov 14, 2016 · 5 comments

Comments

@iamatinkerer
Copy link

iamatinkerer commented Nov 14, 2016

In many files, the import statements use wildcard to import all the classes in the packages

E.g. https://github.com/Microsoft/mssql-jdbc/blob/master/src/main/java/com/microsoft/sqlserver/jdbc/KerbAuthentication.java
import java.util.*;

It is a good practice to specify the specific classes in these imports.

@xiangyushawn
Copy link
Contributor

@iamatinkerer Thank you very much for pointing this out. You are right, it is a good practice to specify classes in imports. We really appreciate your participation and hope you could help us to fix it.

@iamatinkerer
Copy link
Author

@v-xiangs

hope you could help us to fix it.

Can I take this issue and send a PR then?

@ajlam
Copy link
Member

ajlam commented Nov 17, 2016

@iamatinkerer - we are working on getting a development branch created. Once that's available, you can send a PR there. Please stay tuned and thank you for your help 😄

@ahmad-ibra
Copy link

@iamatinkerer
We've just set up a dev branch. You can create a pull request there.

This was referenced Nov 25, 2016
@v-nisidh
Copy link
Contributor

v-nisidh commented Dec 1, 2016

Closing this issue as it is fixed by #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants