Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLServerMetaData Constructor Issue #2404

Closed
mpwong852 opened this issue May 6, 2024 · 1 comment · Fixed by #2405
Closed

SQLServerMetaData Constructor Issue #2404

mpwong852 opened this issue May 6, 2024 · 1 comment · Fixed by #2405

Comments

@mpwong852
Copy link
Contributor

mpwong852 commented May 6, 2024 •
edited
Loading

Driver version

11.2.3.jre17

JAVA/JVM version

Java 17

Is your feature request related to a problem? If so, please give a short summary of the problem and how the feature would resolve it

I need to use create "SQLServerMetaData" like below

(new SQLServerMetaData("row_id", java.sql.Types.INTEGER, 0, 0, true, false, SQLServerSortOrder.Unspecified, -1)

I find that enum SQLServerSortOrder is not public, which cause me can not use this constructor. Can you make it become public ?

Describe the preferred solution

make enum SQLServerSortOrder become public

Tasks
Beta Give feedback
No tasks being tracked yet.
@tkyc
Copy link
Member

tkyc commented May 6, 2024

Looks like an innocuous change. This should be acceptable todo. Feel free to make a PR or I will later.

mpwong852 added a commit to mpwong852/mssql-jdbc that referenced this issue May 7, 2024
@mpwong852
Make enum SQLServerSortOrder become public
8b1140f 
Issue microsoft#2404 

Make this enum to be public, so that people can create "SQLServerMetaData" like below:

new SQLServerMetaData("row_id", java.sql.Types.INTEGER, 0, 0, true, false, SQLServerSortOrder.Unspecified, -1)
@mpwong852 mpwong852 mentioned this issue May 7, 2024
Merged
@Jeffery-Wasty Jeffery-Wasty linked a pull request May 8, 2024 that will close this issue
Make enum SQLServerSortOrder become public #2405
Merged
Jeffery-Wasty pushed a commit that referenced this issue May 10, 2024
@mpwong852
Make enum SQLServerSortOrder become public (#2405)
561bb4f 
Issue #2404 

Make this enum to be public, so that people can create "SQLServerMetaData" like below:

new SQLServerMetaData("row_id", java.sql.Types.INTEGER, 0, 0, true, false, SQLServerSortOrder.Unspecified, -1)
@github-project-automation github-project-automation bot moved this to Closed Issues in MSSQL JDBC Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
MSSQL JDBC
Status: Closed Issues
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make enum SQLServerSortOrder become public mpwong852/mssql-jdbc
2 participants
@tkyc @mpwong852