-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent coding style #4
Comments
@cobookman Thanks for filing an issue about this! As we move forward with developing new features, etc., we will definitely keep coding style consistency in mind. |
I wouldn't mind fixing all the style guide issues. And adding a linter to a github pre-commit hook. Just need a style guide to reference. Here's google's for example: https://google.github.io/styleguide/javaguide.html Btw we are also prone to having style guide issues as well :D. |
+1 for doing this now across the board. Style changes are like taking off a band-aid. Best to get it over with all at once. |
From https://blogs.msdn.microsoft.com/dotnet/2015/02/09/automatic-code-formatter-released-to-github/ |
@cobookman : In current 6.1.3 release we fixed inconsistent coding style. You can find formatting rules in mssql-jdbc_formatter.xml If you are satisfied then I will close this issue otherwise your comments are welcome. |
Fix compilation errors after merging from master
fixed java 8 issue
https://github.com/Microsoft/mssql-jdbc/blob/master/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerColumnEncryptionJavaKeyStoreProvider.java#L81
The text was updated successfully, but these errors were encountered: