Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry logic for prepared statements #628

Closed
TobiasSQL opened this issue Feb 15, 2018 · 4 comments
Closed

Retry logic for prepared statements #628

TobiasSQL opened this issue Feb 15, 2018 · 4 comments

Comments

@TobiasSQL
Copy link
Contributor

https://github.com/Microsoft/mssql-jdbc/blob/a64b9ef50076ab42eba898d76ae45db27ad24c45/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java#L568

@cheenamalhotra

With the re-introduction of retry logic for prepared statements we should not retry if the statement needs to be prepared. For some reason this was removed late in pr #618 and needs to be put back.

I.e. for retryBasedOnFailedReuseOfCachedHandle pass needsPrepare and return false if needsPrepare is true.

@TobiasSQL
Copy link
Contributor Author

In addition, the check for error number 99586 should be removed from the same method.

@cheenamalhotra
Copy link
Member

Hi @TobiasSQL

Created PR #629 - kindly review.

@TobiasSQL
Copy link
Contributor Author

Cool, started review.

@cheenamalhotra
Copy link
Member

Closing issue as requested changes merged to driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants