-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix | Align DatabaseMetadata.getColumns with JDBC 4.3 Specifications #1016
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1016 +/- ##
============================================
- Coverage 53.43% 53.09% -0.34%
+ Complexity 3235 3167 -68
============================================
Files 119 119
Lines 28036 28118 +82
Branches 4680 4694 +14
============================================
- Hits 14980 14930 -50
- Misses 10911 10954 +43
- Partials 2145 2234 +89
Continue to review full report at Codecov.
|
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add test
Existing API with tests, already being tested. |
Please add the new columns to |
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
f582cc6
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
81bb73d
Addresses #1013. Aligns
ResultSet
retrieved fromDatabaseMetaData.getColumns()
with what's described in the JDBC Specifications here. Requires a change in our current MSDN docs and possibly a major version bump.Changes in createSqlKeyWords() due to formatting. Removed Katmai checks and explicitly uses sp_columns_100 as we no longer provide support for SQL Server 2008 and below.
SCOPE_CATALOG, SCOPE_SCHEMA, and SCOPE_TABLE explicitly always returns
NULL
as SQL Server currently doesn't seem to supportREF
column types. The description for these fields is pasted below from the JDBC specification link above: