-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more AE tests and updated AE properties to not read from env variable #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add enclaveAttestationUrl property
lilgreenbird
changed the title
more AE tests and updated AE properties not not read from env variable
more AE tests and updated AE properties to not read from env variable
Nov 19, 2019
Codecov Report
@@ Coverage Diff @@
## dev #1186 +/- ##
============================================
+ Coverage 55.85% 56.59% +0.73%
- Complexity 3550 3643 +93
============================================
Files 130 130
Lines 29332 29332
Branches 4855 4855
============================================
+ Hits 16383 16599 +216
+ Misses 10626 10417 -209
+ Partials 2323 2316 -7
Continue to review full report at Codecov.
|
peterbae
previously approved these changes
Nov 21, 2019
rene-ye
previously approved these changes
Nov 22, 2019
ulvii
reviewed
Nov 27, 2019
src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/AESetup.java
Outdated
Show resolved
Hide resolved
ulvii
reviewed
Nov 27, 2019
src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/AESetup.java
Outdated
Show resolved
Hide resolved
ulvii
reviewed
Nov 27, 2019
src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/JDBCEncryptionDecryptionTest.java
Outdated
Show resolved
Hide resolved
ulvii
reviewed
Nov 27, 2019
src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/JDBCEncryptionDecryptionTest.java
Outdated
Show resolved
Hide resolved
ulvii
reviewed
Nov 27, 2019
src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/JDBCEncryptionDecryptionTest.java
Outdated
Show resolved
Hide resolved
ulvii
reviewed
Nov 27, 2019
ulvii
approved these changes
Nov 28, 2019
peterbae
approved these changes
Nov 28, 2019
rene-ye
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.