Changed serverName sent in LOGIN packet to include instanceName #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilgreenbird
previously approved these changes
Jun 6, 2023
tkyc
previously approved these changes
Jun 6, 2023
|
/azp run CI-mssql-jdbc |
|
No pipelines are associated with this pull request. |
Jeffery-Wasty
force-pushed
the
instanceNameInServerName
branch
from
56ed8cb to
dffaaf7
Compare
…s because we're not checking for instanceName to be filled before sending it in.
…ft/mssql-jdbc into instanceNameInServerName
|
/azp run public-mssql-jdbc.windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run public-mssql-jdbc.linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lilgreenbird
reviewed
Jun 7, 2023
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
tkyc
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match behavior of other drivers, serverName has been modified in LOGIN packet to include instanceName.